[PATCH 07 of 16] phases: make _filterunknown a member function of phasecache

Kevin Bullock kbullock+mercurial at ringworld.org
Thu Jan 3 17:08:11 CST 2013


On Jan 1, 2013, at 7:09 PM, Pierre-Yves David wrote:

> # HG changeset patch
> # User Idan Kamara <idankk86 at gmail.com>
> # Date 1355682488 -7200
> # Node ID 223cb873a170ee0d9c6a9d3ec93aeb8057ca4ffe
> # Parent  42d39c8232de6b32d6e489329bf10656960ae8a7
> phases: make _filterunknown a member function of phasecache
> 
> We'd like the ability to call filterunknown on an existing phasecache
> instance after nodes are destroyed.

It's generally poor form to move a function, change its arguments, and arbitrarily rename its local variables all in one change. Looks okay though.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list