[PATCH 1 of 2 V2-Series-Z] clfilter: add mutable filtering

[Dave S]

My usual minor comments:

On Tue, Jan 8, 2013 at 5:01 AM,  <pierre-yves.david at logilab.fr> wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> # Date 1357645311 -3600
> # Node ID e638511f036813b3595d98647f2079048ecd6476
> # Parent  5a3c71b0e0428d19153bb34485ec6271bc53db9b
> clfilter: add mutable filtering
>
> It filters all mutable changesets, leaving only public changeset unfiltered.

"public changeset_s_"

> This filtering set is expected to be much more stable that the previous one as

"than"

> public changeset are unlikely to disapear.
>

[...]

> +def computemutable(repo):
> +    """compute the set of revision that should be filtered when used a server
> +
> +    Secret and hidden changeset should not pretend to be here."""

"changesets"

I'm not sure what "pretend" means in this context.  Is this comment
related to the assert?

> +    assert not repo.changelog.filteredrevs
> +    # fast check to avoid revset call on huge repo
> +    if util.any(repo._phasecache.phaseroots[1:]):
> +        return frozenset(repo.revs('draft() + secret()'))
> +    return frozenset()
> +
>  # function to compute filtered set
>  filtertable = {'hidden': computehidden,
> -               'unserved': computeunserved}
> +               'unserved': computeunserved,
> +               'mutable':  computemutable}
>  ### Nearest subset relation
>  # Nearest subset of filter X is a filter Y so that:
>  # * Y is included in X,
>  # * X - Y is as small as possible.
>  # This create and ordering used for branchmap purpose.

"an ordering"

>  # the ordering may be partial
>  subsettable = {None: 'hidden',
> -               'hidden': 'unserved'}
> +               'hidden': 'unserved',
> +               'unserved': 'mutable'}
>

I appreciate the hard work you've put into this project.  Thanks.

/dps


-- 
test signature -- please apply at front gate on Tuesdays only.