[PATCH] cvsps: use commitids (when present) to detect changesets

[Frank Kingswood]

On 09/01/13 00:51, Bryan O'Sullivan wrote:
> On Tue, Jan 8, 2013 at 3:45 PM, Bryan O'Sullivan <bos at serpentine.com 
> <mailto:bos at serpentine.com>> wrote:
>
>     Incidentally, your change broke some tests, which I had to fix after
>     the fact:
>
>     http://hg.intevation.org/mercurial/crew/rev/ed923a2d5ae9
>
>
> Ugh, it's worse than I thought. Your change made the test produce 
> different output depending on whether cvs 1.12 or older is installed 
> on the system, so my commit doesn't fix anything, it just changes the 
> set of machines on which the test fails.
Eww, that's awkward.

Of course the *user* will automagically get the right behaviour: if they 
have an old cvs then they probably have no commitids anyway, and if 
their repository has commitids then they probably have a new cvs.
For that reason I would prefer not to make this conditional - as you 
point out it already has the mother of all if expressions.

Could we make the changed testcase require cvs 1.12 or is there no 
mechanism to check dependent tool version numbers?

Frank
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130109/082e42d2/attachment.html>