[PATCH] convert: .hgtags files contain SKIP lines (issue3736)

[Matt Mackall]

On Wed, 2012-12-26 at 22:37 +0100, Mads Kiilerich wrote:
> John Peacock wrote, On 12/26/2012 07:14 PM:
> > # HG changeset patch
> > # User John Peacock <john.peacock at messagesystems.com>
> > # Date 1356542038 18000
> > # Branch bugfix/3736
> > # Node ID 0198939c241c0ed4f6ba40196e24f36eb85aea56
> > # Parent  730b769fb6347d8da3c9e0674e7133bdf61d7a36
> > convert: .hgtags files contain SKIP lines (issue3736)
> >
> > convert is writing SKIP lines into the various .hgtags files when a
> > tag corresponds to a revision marked to be skipped in the conversion
> > (e.g. with filemap).  These lines should only be maintained in the
> > shamap file, not in the .hgtags (where they emit unhelpful warnings).
> > Minimal patch to ignore SKIP lines when updating the .hgtags files.
> 
> Please try to phrase the patch description as a description of the patch 
> and the solution. It might be a good idea to include a description of 
> the problem, but it should make it clear when it is describing the 
> previous bad behaviour and when it is describing the new and better 
> behaviour.

As a more concrete example:

BAD:  convert: .hgtags files contain SKIP lines (issue3736)
GOOD: convert: don't write SKIP lines to .hgtags (issue3736)

BAD:  convert is writing SKIP lines...
GOOD: convert was writing SKIP lines...

-- 
Mathematics is the supreme nostalgia of our time.