[PATCH 2 of 2 V2-Series-Z] clfilter: add impactable filter

[Matt Mackall]

On Tue, 2013-01-08 at 12:13 -0800, Dave S wrote:
> Again, minor stuff ...
> 
> On Tue, Jan 8, 2013 at 5:01 AM,  <pierre-yves.david at logilab.fr> wrote:
> > # HG changeset patch
> > # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> > # Date 1357088561 -3600
> > # Node ID b92288b31fc0c2099068928a7a0ef36cd2dc5a6d
> > # Parent  e638511f036813b3595d98647f2079048ecd6476
> > clfilter: add impactable filter
> >
> > The `mutable` filter still have some chance to get invalidated. This will happen
> 
> "still has some chance"
> 
> > when:
> >
> > - you garbage collect hidden changeset,
> > - public phase is moved backward,
> > - something is changed in the filtering (this could be fixed)
> >
> > So we introduce an even more stable filtering set: everything with a revision
> > number egal or higher than the first mutable changeset is filtered.
> 
> "equal to"

Correcting English in the body of commit messages is probably not worth
the effort. Especially with Pierre-Yves, who tells me his French is
almost as hopeless, and is hard enough for reviewers to keep up with
anyway.

If there's a hierarchy of spelling/grammar importance, it probably looks
like this:

- ui messages
- built-in docs
- wiki
- code identifiers
- commit summaries (because they show up in release notes)
- docstrings
- code and test comments
- commit bodies

That's more or less ranked by how much on-going exposure and impact they
have. The top 5 are worth a resend, the next two want clean-up patches.
But the last is just a nuisance us perfectionists are going to have to
live with.

-- 
Mathematics is the supreme nostalgia of our time.