[PATCH 14 of 22 V2-Series-D] hgweb: pass repo object to revnav construction

Kevin Bullock kbullock+mercurial at ringworld.org
Mon Jan 14 15:18:30 CST 2013


On Jan 14, 2013, at 2:35 PM, Pierre-Yves David wrote:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> # Date 1358181531 -3600
> # Node ID 70aa9a56ce5815fad55ad3f5a72c12287e1bd577
> # Parent  ac76bc6f90545c3252d8cc1e8109e75de22aea4c
> hgweb: pass repo object to revnav construction
> [...]
> 
> diff --git a/mercurial/hgweb/webutil.py b/mercurial/hgweb/webutil.py
> --- a/mercurial/hgweb/webutil.py
> +++ b/mercurial/hgweb/webutil.py
> @@ -39,27 +39,28 @@ def _navseq(step, firststep=None):
>         yield 3 * step
>         step *= 10
> 
> class revnav(object):
> 
> -    def __init__(self, nodefunc):
> +    def __init__(self, repo):
>         """Navigation generation object
> 
> -        :nodefun: factory for a changectx from a revision
> +        :repo: repo object we generate nav for
>         """
> -        self.nodefunc = nodefunc
> +        # used for hex generation
> +        self.cl = repo.changelog

Please use a more descriptive name for the property here...

> [...]
> class filerevnav(revnav):
> -    pass
> +
> +    def __init__(self, repo, path):
> +        """Navigation generation object
> +
> +        :repo: repo object we generate nav for
> +        :path: path of the file we generate nav for
> +        """
> +        # used for iteration
> +        self._hl = repo.changelog
> +        # used for hex generation
> +        self.cl = repo.file(path)

And *especially* here.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list