[PATCH 02 of 22 V2-Series-D] hgweb: move revnavgen into an object

Kevin Bullock kbullock+mercurial at ringworld.org
Mon Jan 14 15:23:30 CST 2013


On Jan 14, 2013, at 2:35 PM, Pierre-Yves David wrote:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> # Date 1358180901 -3600
> # Node ID f3a21139337faae5dd711516b21e7678c1c703ce
> # Parent  869fbec5fd438ce182c7ba5ca2a9a79d9f3fce99
> hgweb: move revnavgen into an object

I *think* this is okay, but it's making my eyes cross. I'm thinking the diff would be slightly less bogacious if you introduce the class as an empty class first. (Not sure if it would make it _much_ better, but I think it's worth a try.)

At the very least you could defer updating the callers by making revnavgen pass thru to the new class.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list