[PATCH 04 of 22 V2-Series-D] hgweb: move the `seq` closure into a dedicated function

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Jan 14 16:16:20 CST 2013


On 14 janv. 2013, at 22:05, Kevin Bullock wrote:

> On Jan 14, 2013, at 2:35 PM, Pierre-Yves David wrote:
> 
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
>> # Date 1357839775 -3600
>> # Node ID d37dda282ef4a22805c8c2e22bb7e5be5cfabbda
>> # Parent  5b869199ef7c34866bce802b43d1764b02e505ab
>> hgweb: move the `seq` closure into a dedicated function
>> 
>> There is not reason for it to be a closure. And this function could use a major
>> reworks.
> 
> Eh? It's not a closure (no variables bound from the enclosing scope). Did you mean "generator"?

hum yeah it is actually a just a generator here.
(There is a lot of actual closure in this code, got me confused when writing the message)

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list