[PATCH stable] graphmod: don't try to visit nullrev (issue3772)

Matt Mackall mpm at selenic.com
Tue Jan 22 13:01:22 CST 2013


On Tue, 2013-01-22 at 13:47 -0500, Augie Fackler wrote:
> On Tue, Jan 22, 2013 at 1:45 PM, Sean Farley
> <sean.michael.farley at gmail.com> wrote:
> > On IRC, Kevin and Pierre-Yves were thinking that this is a bug in
> > 'revrange' and that ":null" should return [-1] instead of [0,-1].
> > Thoughts?
> 
> 
> Interesting. I'm somewhat inclined to agree, as nothing is an ancestor of null.

Agreed. This result is nonsense:

$ hg log -r :null
changeset:   0:9117c6561b0b
user:        mpm at selenic.com
date:        Tue May 03 13:16:10 2005 -0800
summary:     Add back links from file revisions to changeset revisions

changeset:   -1:000000000000
user:        
date:        Thu Jan 01 00:00:00 1970 +0000

As is this one, which is wrong in a different way:

$ hg log -r '(:null)'
changeset:   0:9117c6561b0b
user:        mpm at selenic.com
date:        Tue May 03 13:16:10 2005 -0800
summary:     Add back links from file revisions to changeset revisions

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list