[PATCH V4] hgweb: don't attempt to show hidden bookmarks (issue3774)

Idan Kamara idankk86 at gmail.com
Sat Jan 26 15:10:52 CST 2013


On Sat, Jan 26, 2013 at 8:31 PM, Kevin Bullock <
kbullock+mercurial at ringworld.org> wrote:
>
> # HG changeset patch
> # User Kevin Bullock <kbullock at ringworld.org>
> # Date 1359135834 21600
> # Branch stable
> # Node ID 0af7b5dc492f6573cec334b2ba0c7cebc2320b9c
> # Parent  010d6d3fcfee422f4dd458321c6f540954548d7e
> hgweb: don't attempt to show hidden bookmarks (issue3774)
>
> localrepository._bookmarks is unfiltered, but hgweb gets a filtered
> repo. This fixes the resulting traceback on the 'bookmarks' page.

Isn't the problem a little bit deeper than removing the
filtered bookmarks here? Every other place that will look
at repo._bookmarks will have to do the same check.

Perhaps repoview.__init__ needs to call something that
will cause repo._bookmarks to reconstruct itself (along
with other objects that are based on possibly filtered
csets), which will make those bookmarks not show up in
the first place (repo.invalidatecaches seems like a good
candidate but that requires some extra work).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130126/70449608/attachment.html>


More information about the Mercurial-devel mailing list