2.5 and "hgweb: display difference for a changeset against any parents (issue2810)"

Matt Mackall mpm at selenic.com
Tue Jan 29 15:32:52 CST 2013


On Tue, 2013-01-29 at 21:48 +0100, Mads Kiilerich wrote:
> I just noticed http://hg.intevation.org/mercurial/crew/rev/d605a82cf189 
> and do not feel comfortable about it.
> 
> TLDR: ui regression and potential server load / dos factor regression.
> 
> The change introduces two extra lines in hgweb on /rev/ pages for all 
> changesets, such as:
> change baseline     8216eb592dcd
> current baseline     8216eb592dcd
> or for merges: http://hg.intevation.org/mercurial/crew/rev/e8c9b13c7799
> 
> 1. It thus doesn't address Matt's initial comment "probably no need ... 
> to show multiple links if there's no p2" 
> http://selenic.com/pipermail/mercurial-devel/2012-November/046116.html . 
> It seems like all the discussion focussed on other important requisites 
> and it never came back to look at the actual change. When the page shows 
> a diff against p1 then these two lines will be exactly like the 
> "parents" line and serve no purpose.

You're right, this UI is not ready for prime time.

> 4. It is possible to specify other diff ranges than just parents. That 
> can lead to some confusing diffs that has very little to do with the rev 
> it should show.

This is a feature?

> 5. It is also possible to specify for instance a null:tip range.

I think this is fine.. provided it's a streaming workload rather than a
buffered one.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list