[PATCH] tests: fix toctou race in tinyproxy.py (issue3795)

[Mads Kiilerich]

On 01/31/2013 10:12 PM, Augie Fackler wrote:
>
> On Jan 31, 2013, at 3:06 PM, Matt Mackall <mpm at selenic.com 
> <mailto:mpm at selenic.com>> wrote:
>
>> On Thu, 2013-01-31 at 20:01 +0100, Mads Kiilerich wrote:
>>> # HG changeset patch
>>> # User Mads Kiilerich <madski at unity3d.com <mailto:madski at unity3d.com>>
>>> # Date 1359655993 -3600
>>> # Branch stable
>>> # Node ID 9f4ee36491d826a0714164721e631f026d63b324
>>> # Parent  2a1fac3650a5b4d650198604c82ab59969500374
>>> tests: fix toctou race in tinyproxy.py (issue3795)
>>
>> Looks good.
>
> FWIW, this freaks me out a little bit - I don't understand why there'd 
> be a econnreset here. I may just not have spent enough time squinting 
> at the code.

Me neither.

It could in principle be "poor man's don't continue" ... but I don't see 
that happen in that test.

But the problem we see is that _if_ it (or some other error) happens, 
then it triggers a bug in tinyproxy. So I'm not sure if it is good or 
bad to fix that bug.

/Mads
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130131/2da57dea/attachment.html>