[PATCH RFC] hgweb: code selection without line numbers in file source view

Laurens Holst laurens.nospam at grauw.nl
Wed Jul 3 11:22:47 CDT 2013


Op 03-07-13 14:05, Martin Geisler schreef:
> Alexander Plavin <me at aplavin.ru> writes:
>
> (You're top-posting. It is more convenient if you put your comments
> after the thing they apply to.)
>
>> In this case the whole lines are links, which makes it impossible to
>> select a random region (at least I couldn't do it) and isn't a good
>> thing anyway as for me. Also, both embedded and leading tabs are lost
>> on copy (tried several times, as you state the opposite, but same
>> result).
> Okay, you have a good point about the links making the text
> un-selectable. What do you think about the version below where we use
> JavaScript to install a click handler? I can mark text anywhere and when
> doing so the URL is updated to include the relevant ID, so that one can
> copy-paste the URL.

If it fixes the copy/pasting of white space, sounds great.

However, in terms of the click handling, I'd like to refer to my earlier 
mail:

http://selenic.com/pipermail/mercurial-devel/2013-May/051431.html

" I don't like that the screen jumps when you select something. I like 
to select where I'm reading so I don't lose track, and this heavily 
interferes with that. It would be better if only clicking on the line 
number would change the target."

I think the way Alexander implemented the click handler after that was nice.

~Laurens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130703/38378b16/attachment.html>


More information about the Mercurial-devel mailing list