[PATCH 1 of 3 RFC V4] hgweb: code selection without line numbers in file source view

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Jul 4 17:58:39 CDT 2013


On 5 juil. 2013, at 00:32, Alexander Plavin wrote:

> Firstly, thanks for the idea and implementation!
> 
> 2013/7/5 Martin Geisler <martin at geisler.net>:
>> Alexander Plavin <me at aplavin.ru> writes:
>> 
>>> # HG changeset patch
>>> # User Alexander Plavin <me at aplavin.ru>
>>> # Date 1372933124 -14400
>>> #      Thu Jul 04 14:18:44 2013 +0400
>>> # Node ID a1de30293d0e140b14e9d8ed5f2e7540907a81b1
>>> # Parent  d7b4aa1049d3fbbc2b8d24114afad82586c49db3
>>> hgweb: code selection without line numbers in file source view
>> 
>> Thanks for turning my demo into a full patch!
>> 
>> I would use the commit message to explain a few things:
> 
> This is RFC, as a flag says, so commit message will be extended for
> sure. I've sent it to be sure everyone agrees with this solution.

But we can't comment something that you does explain. In order to evaluate this patch we need to understand how you solution achieve its goal, the pro and cons of the approach, etc.

One line commit description are be banned on a general basis.

-- 
Pierre-Yves


More information about the Mercurial-devel mailing list