[PATCH] (issue3253) 'hg cat -r [rev]' doesn't work with renamed files

Matt Mackall mpm at selenic.com
Mon Jul 8 16:33:08 CDT 2013


On Mon, 2013-07-08 at 23:50 +0300, Iulian Stana wrote:
> 
>         This format is so, so wrong.
>         
> Yeah.... probably it's match better with '(issue3252) cat: doesn't
> work with renamed files'

First:

$ hg log --template '{desc|firstline}\n' | grep '^[(]' | wc
      0       0       0
$ hg log --template '{desc|firstline}\n' | grep '[)]$' | wc
   1546   12462   91687

We have a huge example corpus of commit summaries, and none of them have
the issue bit at the beginning.

Second: the actual text here is completely unhelpful. Are you saying it
doesn't work before or after this patch? Is that a good thing or a bad
thing? If it's a bad thing that you fixed, how did you fix it? Instead
-describe what you did-. For instance:

cat: added --follow flag (issue3253)

> What about the code?  

Insofar as I think getting the basics of patch submission down is much
more important for your GSoC project than this particular patch, I
skipped reading the actual code for now.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list