[PATCH V2] gpg: show "Unknow KEYID xxx" when the status is ERRSIG

Kevin Bullock kbullock+mercurial at ringworld.org
Tue Jul 9 23:10:04 CDT 2013


On 1 Jul 2013, at 9:55 PM, elson.wei at gmail.com wrote:

> # HG changeset patch
> # User Wei, Elson <elson_wei at primevolt.com>
> # Date 1372733547 -28800
> #      Tue Jul 02 10:52:27 2013 +0800
> # Node ID f56f76c8d5f52460985d2087737b447e3f3555ec
> # Parent  648d1974b3f328947ee6cf2d00c66815a33cd208
> gpg: show "Unknow KEYID xxx" when the status is ERRSIG

I count at least 2 different things this patch is doing:

1. Changing the error message for unknown keys.
2. Changing how error messages are handled by sigcheck.

That means it should be at least 2 separate patches. It would also be helpful to have an example of the new output in the long commit description.

Also, why is KEYID smushed together and in ALL CAPS? "Unknown key ID XXX" would be better. Even better would be to only use the last 8 digits of the key ID (this is how gpg(1) shows keys in most instances).

Thanks for the patch -- please read <http://mercurial.selenic.com/wiki/ContributingChanges> if you haven't already.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list