[PATCH V2 1/2] diff: add the --output option

[Augie Fackler]

On Jul 9, 2013, at 7:43 PM, "Ahmed S. Darwish" <darwish.07 at gmail.com> wrote:

>>> +def fsfriendly(user):
>>> +    """return committer's username in a short and filesystem-friendly
>>> +    manner.  This basically implies removing email info, white spaces,
>>> +    and other problematic characters for common filesystems.
>>> +    reference: MSDN - Naming Files, Paths, and Namespaces.
>>> +    """
>>> +    user = re.sub('\<[^<]*@[^>]*\>', '', user)
>>> +    user = re.sub("[\W]", '', user)
>>> +    return user.lower()
>>> +
>> 
>> This function could really stand to be its own patch.
>> 
> 
> So should I now send a V3 version for this patch series?
> 

Yes please.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130709/5114f4e5/attachment.html>