Hint for setting the username

[Arne Babenhauserheide]

Hi Simon,

Am Dienstag, 9. Juli 2013, 17:32:30 schrieb Simon King:
> > -            raise util.Abort(_('no username supplied (see "hg help config")'))
> > +            raise util.Abort(_('no username supplied (see "hg help config")\n'
> > +                               '(add section [ui] with username = YOURNAME in %s)')%scmutil.userrcpath()[0])
> (Presuming to be qualified to review patches, which I'm really not)

Judging from your post, you are.

> This falls foul of a number of rules on
> http://mercurial.selenic.com/wiki/ContributingChanges and
> http://mercurial.selenic.com/wiki/CodingStyle. Specifically, the ones
> about patch description, line length, and spaces around operators.
> 
> From a more technical point of view, the Abort exception accepts a
> "hint" keyword parameter. Hints will automatically be displayed after
> the main message:
> 
>   http://selenic.com/hg/file/fbdac607bff3/mercurial/dispatch.py#l52

That’s nice to know, thanks!

> The irony (or whatever) of rejecting a patch that aims to make it
> easier for people to contribute changes is not lost on me...

well… you can also take and improve it.

As I wrote in another mail, the free time in which I’m able to concentrate is quite limited nowadays (mostly due to family responsibilities), so I had the chance of doing a quick patch or not doing anything… 

Best wishes,
Arne
-- 
1w6 sie zu achten,
sie alle zu finden,
in Spiele zu leiten
und sacht zu verbinden.
→ http://1w6.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 316 bytes
Desc: This is a digitally signed message part.
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130710/4e4b5fd6/attachment.pgp>