[PATCH V2 1/2] diff: add the --output option

[Matt Mackall]

On Fri, 2013-07-12 at 20:46 +0200, Ahmed S. Darwish wrote:
> On Fri, Jul 12, 2013 at 12:36:40PM -0500, Kevin Bullock wrote:
> > On 11 Jul 2013, at 4:02 PM, Ahmed S. Darwish wrote:
> > 
> > > On Tue, Jul 09, 2013 at 10:25:14PM -0500, Kevin Bullock wrote:
> > >> Oh, and repo.ui.username() is _not_ (necessarily) the
> > >> committer; I'm not sure that "committer" has any meaning
> > >> for diff unless it's of a single rev.
> > > 
> > > Indeed.
> > > 
> > > I'll thus modify the behavior to the following: If the '-c REV'
> > > option was added to diff, include _that_ commit's author. In all
> > > other cases, use repo.ui.username().
> > > 
> > >> 
> > >> It _would_, however, have meaning for 'export'. And "date"
> > >> would have a different meaning for diff vs. export as well.
> > >> 
> > > 
> > > I've ommitted "date"(%d) and "committer"(%u) from the documentation
> > > of 'hg export --output' on purpose. I did not feel it would be of
> > > much importance there. They're thus, at least for now, exclusive to
> > > diff --output.
> > 
> > Except that they're not, if I understand your patch correctly --
> > they're just undocumented for other things that use makefilename.
> > 
> 
> Yes. I'll check if the new flags can be added exclusively to
> 'diff --output'.

No, please don't. Just because you haven't thought of a use for a
feature that you've trivially created doesn't mean it doesn't exist.

-- 
Mathematics is the supreme nostalgia of our time.