[PATCH 1 of 2] hgweb: change highlighted line color to be different from 'inserted' color

[Alexander Plavin]

2013/7/17 Martin Geisler <martin at geisler.net>:
> Alexander Plavin <me at aplavin.ru> writes:
>
>> 2013/7/16 Martin Geisler <martin at geisler.net>:
>>> Alexander Plavin <me at aplavin.ru> writes:
>>>
>>>> 2013/7/15 Martin Geisler <martin at geisler.net>:
>>>>> Alexander Plavin <me at aplavin.ru> writes:
>>>>>
>>>>>> # HG changeset patch
>>>>>> # User Alexander Plavin <me at aplavin.ru>
>>>>>> # Date 1373722313 -14400
>>>>>> #      Sat Jul 13 17:31:53 2013 +0400
>>>>>> # Node ID c4f25e9184601161b1f24aa41e2c9d6957b95654
>>>>>> # Parent  3f19e6106f17298dca51f3d3f3234590af518f4b
>>>>>> hgweb: change highlighted line color to be different from 'inserted' color
>>>>>
>>>>>> diff -r 3f19e6106f17 -r c4f25e918460 mercurial/templates/static/style-paper.css
>>>>>> --- a/mercurial/templates/static/style-paper.css Sat Jul 13
>>>>>> 00:57:56 2013 +0400
>>>>>> +++ b/mercurial/templates/static/style-paper.css Sat Jul 13
>>>>>> 17:31:53 2013 +0400
>>>>>> @@ -253,7 +253,7 @@
>>>>>>  }
>>>>>>
>>>>>>  .sourcelines > span:target {
>>>>>> -  background-color: #ffff99;
>>>>>> +  background-color: #bfdfff;
>>>>>>  }
>>>>>
>>>>> Sounds good, but I would:
>>>>>
>>>>> 1. explain in human terms that you're changing a faint yellow (#ffff99)
>>>>>    to a faint blue (#bfdfff)
>>>>
>>>> Sure, will add to commit message.
>>>
>>> Sounds good.
>>>
>>>>> 2. argume somehow that the new color is okay for color blind people
>>>>>    (there were a big discussion earlier that resulted in the yellow-ish
>>>>>    color being selected over the usual green for inserted lines).
>>>>
>>>> How can I argume this? I've tried with a simulator of different color
>>>> blindness types now, and this light blue background looks a) different
>>>> enough from other backgrounds, and b) text doesn't lose distinction on
>>>> it.
>>>
>>> That is how I would argue it :) I guess you found the discussion I
>>> referred to and could test the new color the same way as the other
>>> colors were tested then.
>>
>> Nope, couldn't find the discussion as don't see where I can search for
>> the ML archives.
>
> Aha, good that you say that! I always use the mirror here:
>
>   http://mercurial.markmail.org/
>
> I think it's quite nice with the way it lets you zoom in on the
> list/month/poster you want. It's linked and described as "searchable" on
> the wiki:
>
>   http://mercurial.selenic.com/wiki/MailingLists
>
> However, if all one finds is the good old Pipermail interface, then I
> can understand how one could give up there. Maybe we could include a
> link to the searchable archives from Pipermail?

This is awesome, and searches better than google :) I found that
discussion on the first try. And there mpm said that the (light?) blue
background is ok for colorblind people (and my experiments agree
here), but it looks 'too busy'. Here I think it's not a problem,
'cause the whole page can have only one highlighted line.

>
> --
> Martin Geisler