Code duplication in Mercurial

Kevin Bullock kbullock+mercurial at ringworld.org
Wed Jul 17 15:00:15 CDT 2013


On 17 Jul 2013, at 1:39 PM, Pierre-Yves David wrote:

> 
> On 14 juil. 2013, at 01:45, Alexander Plavin wrote:
> 
>> 2013/7/14 Martin Schröder <martin.schroeder at nerdluecht.de>:
>>> Maybe it would be helpful to publish the output of CloneDigger so that
>>> not everyone needs to run it.
>> 
>> Sure: http://aplavin.ru/hg-clonedigger-report.html - output for the
>> full Mercurial codebase.
>> 
>>> 
>>> And maybe you can submit patches deduplicating code?
>> 
>> As my summer project is improving hgweb, I'm not going to deal with
>> duplication soon (maybe only at the parts of code which I edit), as
>> it's quite out of scope. So, probably no deduplicating from me until
>> October :)
> 
> I spend some time in the hgweb code a few moth ago and I can testify it is not in a good shape (no offense for authors). Improving a software is not just about adding feature, it is also about maintaining the code. So cleaning up the hgweb code qualifies as "improving hgweb" in my opinion. I'm not your mentors but improving code quality could be a valid side objective for you gsoc.

If there is any de-duplication or refactoring that is _tangentially_ related to your project goals, I'd say that's in scope. It will likely make your own later work easier.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list