RFC, why do we need no-check-code?

[Simon Heimberg]

Am 17.07.2013 02:18, schrieb Augie Fackler:
> On Jul 16, 2013, at 7:31 PM, Simon Heimberg <simohe at besonet.ch> wrote:
>
>> In e033a7d444 no-check-code is removed from all places where it was by
>> accident. There were no places left.
>> Therefore I ask what we need no-check-code for. When do we want to skip
>> checking an entire file? check-code-ignore which ignores one line is
>> better. Event better is to list the exception in the test result. Best
>> is of course to fix the failure.
>>
>> I propose to remove no-check-code support from check-code.py and from
>> filterpyflakes.
>> If we really need no-check-code, we should avoid to use it by accident.
>> Writing a code-check rule is difficult. It needs special handling
>> because the file is skipped because it contains this statement. And
>> no-check-code is often written in the comment which is not checked.
> We've got a couple of Python files that are from other projects (mostly relating to our i18n work or http support), and don't match our coding style. We absolutely need it, even though it's a little dangerous.
I see. And right, now I found them. Looks like the files deeper in the 
hierarchy that my search went down...
I will choose the other way.
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel at selenic.com
>> http://selenic.com/mailman/listinfo/mercurial-devel