[PATCH] parsers: it should check the other interesting before decreasing ninteresting (issue3984)

Siddharth Agarwal sid0 at fb.com
Thu Jul 25 15:41:47 CDT 2013


On 07/25/2013 01:10 PM, Siddharth Agarwal wrote:
> This patch LGTM, though a better summary and perhaps a test would be 
> nice. With this patch, the invariant that ninteresting is the number 
> of non-zero elements in the interesting array is preserved.

Unfortunately, there's another bug in the C code with the calculation of 
the final list. I'll send an updated patchset once I figure out how to 
test this.


More information about the Mercurial-devel mailing list