[PATCH 3 of 3 stable V3] ancestor.deepest: ignore ninteresting while building result (issue3984)

Matt Mackall mpm at selenic.com
Fri Jul 26 13:58:58 CDT 2013


On Thu, 2013-07-25 at 16:08 -0700, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1374788595 25200
> #      Thu Jul 25 14:43:15 2013 -0700
> # Branch stable
> # Node ID 83778e4c541197d2af4ea335d6da137c836e0619
> # Parent  9324b72460bba1e668851e57928ff7b7cc75aa06
> ancestor.deepest: ignore ninteresting while building result (issue3984)
> 
> ninteresting indicates the number of non-zero elements in the interesting
> array, not the number of elements in the final list. Since elements in
> interesting can stand for more than one gca, limiting the number of results to
> ninteresting is an error.

These are queued, thanks. Excellent use of debugbuilddag.

Elson, excellent job finding the first piece of this bug. After 2.7, we
should really think about documenting this algorithm as its inventor can
no longer remember how it works.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list