[PATCH]change posix test for symlinks

Kevin Bullock kbullock+mercurial at ringworld.org
Mon Jul 29 12:07:27 CDT 2013


On 29 Jul 2013, at 1:05 AM, DeathGorePain wrote:

> You go off attacking my code calling it "voodoo", critising me for a
> lack of explanation. Did you even read the stackoverflow post and my
> commit message?
> 
>> hg-checklink:change posix test for symlinks
>> 
>> old:link to currentdir(hg root), if fail: leave artefacts
>> new:link to temporary file and clean up when method exits

...which says nothing about _why_ the prior code failed on sshfs in particular.

It's also unlikely that many people read the stackoverflow link; if there's relevant context there, it should go in the commit message.

Nice that you took some effort to get hg working on sshfs; would've been better if you had taken the time to fully understand and explain what the problem was. That's a precondition to having your patch accepted: you have to convince us it's both necessary and correct.

Not sure what was confusing about the testsuite's output; `make tests` should show a bunch of dots as it progresses. On failures, it shows a unified diff between the expected and actual output.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list