[PATCH 1 of 5 V2] hgweb: code selection without line numbers in file code view

Laurens Holst laurens.nospam at grauw.nl
Sat Jun 1 07:03:57 CDT 2013


Op 6/1/13 11:52 AM, Pierre-Yves David schreef:
> On 31 mai 2013, at 12:51, Alexander Plavin wrote:
>
>> # HG changeset patch
>> # User Alexander Plavin <me at aplavin.ru>
>> # Date 1369988709 -14400
>> #      Fri May 31 12:25:09 2013 +0400
>> # Node ID 88877f36f75166b4bd12317cf3f986b17ae8cf2c
>> # Parent  1bef6f99a12d9062e737bb623da627719a3987e6
>> hgweb: code selection without line numbers in file code view
>>
>> File code is presented as HTML ordered list, so that line numbers
>> are not selected with the code itself. Long lines are wrapped for convenience.
> This drop the ability to link to a specific line. What's you plan for that ?

That feature is brought back in patch 3. If you go to the test page, 
you’ll notice that if you click on the line number it will link to that 
line. It does this by adding an event handler with JavaScript.

Doing it like that hurts accessibility a bit, but I don’t think it’s an 
essential feature for the blind, and is offset by the improvement in 
semantics.

~Laurens


More information about the Mercurial-devel mailing list