[PATCH] run-tests: call Threads constructor with keyword arguments

Simon Heimberg simohe at besonet.ch
Mon Jun 10 11:51:38 CDT 2013


# HG changeset patch
# User simon at laptop-tosh
# Date 1370789348 -7200
# Node ID 967b89a1b89a76cde289c8d71c2da807751ef2ab
# Parent  a3645a98eda5ab9cfe5eba4a3ccda6745d5f3fef
run-tests: call Threads constructor with keyword arguments

This is suggested in the python documentation
(on http://docs.python.org/2/library/threading.html#thread-objects)

diff -r a3645a98eda5 -r 967b89a1b89a tests/run-tests.py
--- a/tests/run-tests.py	Son Jun 09 16:42:55 2013 +0200
+++ b/tests/run-tests.py	Son Jun 09 16:49:08 2013 +0200
@@ -1092,7 +1092,7 @@
                 test = tests.pop(0)
                 if options.loop:
                     tests.append(test)
-                t = threading.Thread(None, job, args=(test, count))
+                t = threading.Thread(target=job, args=(test, count))
                 t.start()
                 running += 1
                 count += 1


More information about the Mercurial-devel mailing list