[PATCH 0 of 2] re2 for check-code, working around missing finditer

Matt Mackall mpm at selenic.com
Thu Jun 20 17:16:58 CDT 2013

On Thu, 2013-06-13 at 01:34 +0200, Simon Heimberg wrote:
> There are two implementations of re2
> Facebooks implementation does not have finditer
>  https://github.com/facebook/pyre2/blob/master/README.rst#missing-features
> But the one from axiak does
>  https://github.com/axiak/pyre2/blob/master/src/re2.pyx#L513

This popped up a couple days ago:


..which makes me inclined to pass on axiak-only support for now. If we
can tweak check-code to not use finditer and thus be bi-compatible,
that'd be great.

(As it happens, my own test servers come with Facebook's version
pre-installed, which makes it a nuisance for me to even test the axiak

Mathematics is the supreme nostalgia of our time.

More information about the Mercurial-devel mailing list