[PATCH] templater: add strip function with chars as an extra argument

Alexander Plavin me at aplavin.ru
Tue Jun 25 13:12:05 CDT 2013


2013/6/25 Matt Mackall <mpm at selenic.com>

> On Tue, 2013-06-25 at 21:57 +0400, Alexander Plavin wrote:
> > # HG changeset patch
> > # User Alexander Plavin <me at aplavin.ru>
> > # Date 1372179742 -14400
> > #      Tue Jun 25 21:02:22 2013 +0400
> > # Node ID b86e8cb9939493bdccce4ec5301cd0b7ea5c9cd7
> > # Parent  1bef6f99a12d9062e737bb623da627719a3987e6
> > templater: add strip function with chars as an extra argument
> >
> > This allows specifying characters to strip, like the Python strip
> function.
>
> This'll want documentation/examples. That lives in mercurial/help/, I
> think. A one-line test case would be good too, see
> test-command-template.t.
>

This function makes not much sense for commands, like hg log. Also this
function is quite obvious, and I didn't find tests for multiple other
function there too. So, it seemed to me that test isn't needed. As for
documentation, will add it. I thought that the functions list is
autogenerated, like filters one.

>
> --
> Mathematics is the supreme nostalgia of our time.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130625/5e6c774b/attachment.html>


More information about the Mercurial-devel mailing list