AW: [PATCH] tests: simplify and document the sorting of pyflake messages

[Simon He.]

I'd prefer to simplify the algorythm. Could you unqueue please? I will send the alternative patch soon.


-----Ursprüngliche Nachricht-----
Von: Matt Mackall [mailto:mpm at selenic.com] 
Gesendet: Mittwoch, 26. Juni 2013 21:06
An: Simon Heimberg
Cc: Mercurial-devel
Betreff: Re: [PATCH] tests: simplify and document the sorting of pyflake messages

On Sat, 2013-06-15 at 00:07 +0200, Simon Heimberg wrote:
> # HG changeset patch
> # User Simon Heimberg <simohe at besonet.ch> # Date 1371247580 -7200 # 
> Node ID 7a35b0923e5f76d96f8e789071adf81e4862301f
> # Parent  f235457a184b6003495f1a5b6c1003590186f1ab
> tests: simplify and document the sorting of pyflake messages
> 
> The pyflake messages are simply ordered by message type, path and line no.
> The other details are not used for sorting.
> 
> The previous ordering looks complicated and illogically.
> It was the following order ('\3:\5:\4:\1:\2:' + line):
>   message (\3 and \5)
>   var name (\4)
>   path (\1)
>   line no (\2)
>   line reference
> Ordering by var name before path looks illogically for me.

Queued for default, thanks. I suspect Augie is a little over-exposed to the 'yo dawg' meme.

--
Mathematics is the supreme nostalgia of our time.