[PATCH 3 of 3] tests: run pyflakes on files from manifest which could be python files

[Kevin Bullock]

On 26 Jun 2013, at 4:35 PM, Simon Heimberg wrote:

> # HG changeset patch
> # User Simon Heimberg <simohe at besonet.ch>
> # Date 1372281181 -7200
> # Node ID dac1a6dc604928b5fc4a74acd37d79d95fe3c28a
> # Parent  fd803f71beba3b8e63920f74952b3193810a7413
> tests: run pyflakes on files from manifest which could be python files
> 
> diff -r fd803f71beba -r dac1a6dc6049 tests/test-check-pyflakes.t
> --- a/tests/test-check-pyflakes.t	Mit Jun 26 23:12:55 2013 +0200
> +++ b/tests/test-check-pyflakes.t	Mit Jun 26 23:13:01 2013 +0200
> @@ -1,6 +1,21 @@
>   $ "$TESTDIR/hghave" pyflakes || exit 80
>   $ cd "`dirname "$TESTDIR"`"
> -  $ pyflakes mercurial hgext 2>&1 | "$TESTDIR/filterpyflakes.py"
> +
> +run pyflakes on all tracked files ending in .py or without a file ending
> +(skipping binary file random-seed)
> +  $ hg manifest | egrep "\.py$|^[^.]*$" | grep -v /random_seed$ \

You should redirect stderr to /dev/null here to avoid the "obsolete feature not enabled but N markers found!" warning; cf. test-check-code-hg.t.

It would also be kinda nice to put this patch first in the series, with all the issues you fixed in the other patch, so that we can see in history what it does.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock