[PATCH] strip: make --keep option not set all dirstate times to 0

Kevin Bullock kbullock+mercurial at ringworld.org
Fri Mar 8 12:51:57 CST 2013


On 8 Mar 2013, at 12:44 PM, Bryan O'Sullivan wrote:

> On Wed, Mar 6, 2013 at 8:23 PM, Durham Goode <durham at fb.com> wrote:
> +            changedfiles = []
> +            for f, m, args, msg in actions:
> +                # blindy reset the files, regardless of actual action necessary
> +                changedfiles.append(f)
> 
> changedfiles = [a[0] for a in actions]

Indeed. The list comprehension is usually faster, right? (I haven't trained myself to compulsively spot this pattern yet.)

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list