[PATCH 1 of 2 RFC] completion: add a debugpathcomplete command
Kevin Bullock
kbullock+mercurial at ringworld.org
Thu Mar 14 13:23:39 CDT 2013
On 14 Mar 2013, at 12:37 PM, Bryan O'Sullivan wrote:
> On Thu, Mar 14, 2013 at 9:53 AM, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:
>> ...but I just tried to create a read-only proxy that gets you the unsorted map, and it's easy and functional.
>>
> Sure. But I don't want to add it. It's complex, slow, and defends us against a problem we do not have.
Law of Demeter violations are something we need _less_ of in the codebase, not more. My naïve example is almost certainly not the right solution, but I still don't like pulling out a _marked private_ dict from inside an object just so that you can complete filenames faster.
Could we just add an accessor to dirstate for the unsorted map keys?
pacem in terris / мир / शान्ति / سَلاَم / 平和
Kevin R. Bullock
More information about the Mercurial-devel
mailing list