[PATCH 1 of 2] blackbox: prevent failed I/O from causing hg to abort

Durham Goode durham at fb.com
Tue Mar 19 18:50:44 CDT 2013


On 3/19/13 4:00 PM, "Bryan O'Sullivan" <bos at serpentine.com> wrote:

># HG changeset patch
># User Bryan O'Sullivan <bryano at fb.com>
># Date 1363734026 25200
># Node ID 9a44c44337c701d6212454b993caa5f778254f56
># Parent  de0601436fb6156c173abc2d7a6099f0c0b6b7cb
>blackbox: prevent failed I/O from causing hg to abort
>
>Instead, we simply print a warning message if opening the blackbox log
>file fails, or if writing to it fails.

Overall looks good.  Should we even bother writing out a warning?  I can
imagine the case where the repo is readonly for most users, but still
wants the blackbox on for admin users.  In that case the normal users
would see the warning every time right?



More information about the Mercurial-devel mailing list