[PATCH] run-tests: only sort files when not given as argument

Pierre-Yves David pierre-yves.david at logilab.fr
Thu Mar 21 05:26:45 CDT 2013


On Thu, Mar 21, 2013 at 09:28:58AM +0100, Simon Heimberg wrote:
> # HG changeset patch
> # User Simon Heimberg <simohe at besonet.ch>
> # Date 1363852581 -3600
> # Node ID d3b734662b82e8232a4d43b549d5afc29421312d
> # Parent  f56278a0a0c56fe0c6c02ef8e23dbe0cadb9df69
> run-tests: only sort files when not given as argument
> 
> os.listdir returns the files in any order. This has to be sorted.
> But when given as argument, the user should be allowed to set any order.
> 
> This restores the behaviour before 9848a94e2a.

sounds good to me

> diff -r f56278a0a0c5 -r d3b734662b82 tests/run-tests.py
> --- a/tests/run-tests.py	Mit Mär 20 13:40:06 2013 -0700
> +++ b/tests/run-tests.py	Don Mär 21 08:56:21 2013 +0100
> @@ -1244,8 +1244,7 @@
>          checktools()
>  
>          if len(args) == 0:
> -            args = os.listdir(".")
> -        args.sort()
> +            args = sorted(os.listdir("."))
>  
>      tests = args
>  
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

-- 
Pierre-Yves David

http://www.logilab.fr/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130321/4668e1be/attachment.pgp>


More information about the Mercurial-devel mailing list