[PATCH 2 of 4] largefiles: fix _always for match overrides

Kevin Bullock kbullock+mercurial at ringworld.org
Mon Mar 25 12:07:30 CDT 2013


On Mar 23, 2013, at 3:56 AM, Siddharth Agarwal wrote:

> On 03/22/2013 09:33 PM, Kevin Bullock wrote:
>> On 22 Mar 2013, at 9:37 PM, Siddharth Agarwal wrote:
>> 
>>> # HG changeset patch
>>> # User Siddharth Agarwal <sid0 at fb.com>
>>> # Date 1364004188 25200
>>> #      Fri Mar 22 19:03:08 2013 -0700
>>> # Node ID 90293fb6b3d77c76a5985f7003bdeac8d60878e0
>>> # Parent  54e5c022f4d4e7b7f536d395268a04313f532340
>>> largefiles: fix _always for match overrides
>> What's broken about it?
> 
> The always function returns true on those objects even though it shouldn't. I thought that was reasonably obvious from context.

I might just be being thick, but it's not obvious to me from the visible context in the patch. My point was that your commit messages on the first two patches should list the motivation for them. For the last two, the performance gains are the obvious motivation.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list