[PATCH 8 of 9] manifestmerge: use dicthelpers.diff and join

[Siddharth Agarwal]

On 03/25/2013 10:26 AM, Bryan O'Sullivan wrote:
> On Sun, Mar 24, 2013 at 5:27 PM, Siddharth Agarwal <sid0 at fb.com 
> <mailto:sid0 at fb.com>> wrote:
>
>     Any operation that uses manifestmerge benefits. With the C
>     dicthelpers: [...]
>
>
> What is the difference if using the Python dicthelpers? From the rest 
> of this patch description, it looks like the C code is saving only 0.1 
> seconds, which would seem to put it squarely in the "not worth it" 
> category. 

Seems to be closer to 0.15 seconds (times 4 = 0.6 seconds for rebase) in 
practice. hg update . in 1.75 seconds, hg update .^ in 2.25 and hg 
rebase -r . -d .~6 in 10.8.

Whether it's worth it or not, I don't know. I myself was surprised at 
how relatively fast the Python dicthelpers turned out to be.