[PATCH] blackbox: defer opening a log file until needed (issue3869)

Bryan O'Sullivan bos at serpentine.com
Tue Mar 26 19:17:21 CDT 2013


On Tue, Mar 26, 2013 at 4:50 PM, Durham Goode <durham at fb.com> wrote:

> LGTM.  Should we close the file after every write as well so we don't
> encounter any other cases where NFS can't delete the tree while it's open?
>

Maybe, but I haven't seen any such cases arise. I think this could maybe be
provoked by replacing a subrepo that points at one URL with another, but I
haven't figured out how, and absent a way to reproduce such a hypothetical
error, I'm not sure I'm bothered.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130326/2671ef21/attachment.html>


More information about the Mercurial-devel mailing list