[PATCH 3 of 8] clone: add an argument to determine if a clone should stream files

Durham Goode durham at fb.com
Mon May 6 15:39:51 CDT 2013


On 5/6/13 12:59 PM, "Matt Mackall" <mpm at selenic.com> wrote:

>On Mon, 2013-05-06 at 12:36 -0700, Durham Goode wrote:
>> # HG changeset patch
>> # User Durham Goode <durham at fb.com>
>> # Date 1367429921 25200
>> #      Wed May 01 10:38:41 2013 -0700
>> # Node ID e5c4416f076c1a99ea99fe83da9a009a15ca33ea
>> # Parent  4da152c208d0f853bd03781a5d7a9b9cc8716a19
>> clone: add an argument to determine if a clone should stream files
>> 
>> This adds an argument to wireproto.stream to specify if a streaming
>>clone should stream
>> file contents. This allows an extension to prevent file contents from
>>being
>> streamed.
>
>Adding arguments to existing commands doesn't work with ssh unless the
>command is already spec'ed to accept varargs, ie has a '*' here:
>
>http://www.selenic.com/hg/file/a718a0ba6787/mercurial/wireproto.py#l638
>
>..and we can't add '*' to existing commands.
>

I don't actually need this argument exposed via the wireproto.commands
network contract. The extension invokes this method with the appropriate
argument via another means.  Adding the optional argument doesn't seem to
prevent hg from calling the function using the old no-arguments network
contract.



More information about the Mercurial-devel mailing list