[PATCH 1 of 4 V2] clone: move file stream walk to a separate function

Kevin Bullock kbullock+mercurial at ringworld.org
Tue May 7 13:45:59 CDT 2013


On 7 May 2013, at 1:44 PM, Durham Goode wrote:

> On 5/7/13 11:23 AM, "Kevin Bullock" <kbullock+mercurial at ringworld.org>
> wrote:
> 
>> On 6 May 2013, at 10:14 PM, Durham Goode wrote:
>> 
>>> # HG changeset patch
>>> # User Durham Goode <durham at fb.com>
>>> # Date 1367429921 25200
>>> #      Wed May 01 10:38:41 2013 -0700
>>> # Node ID 672183bf736b045705760066ef102a0a4cb52cca
>>> # Parent  a718a0ba6787ae9546d0aa453c8a7dae25d4405b
>>> clone: move file stream walk to a separate function
>>> 
>>> Moves the file walk out of the stream method so that extensions can
>>> override it.
>>> Also adds store.topfiles() that only walks the non data/ files.
>> 
>> This sure looks like two changes to me...
> 
> They are related from a how-they-will-be-used point of view.  I figured
> they were small enough to fit together.  I'll split it up in V3.

Related changes != single change. They're both teeny, so it's not a huge deal, but if you're re-sending it'd be good to split, yeah.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list