[PATCH stable v2] hgweb, i18n: avoid parameterized search mode description

Matt Mackall mpm at selenic.com
Mon Nov 4 14:51:05 CST 2013


On Mon, 2013-11-04 at 17:46 -0200, Wagner Bruna wrote:

> Let me get this out of the way first: IMHO it's EXTREMELY inefficient to
> approach a communication problem with further non-communication.

For future reference, "???" = "I am utterly mystified by this patch." 

The problem here was that I didn't spot the "Assuming {blah}" in the
templates and "parameterized" didn't suggest "bogus translation of
string fragments" to me.

> The search mode description can't be translated by itself, since
> it's displayed as part of an English-only template phrase (the
> "Assuming ..." / "Use ... instead" bits). We shoud either translate
> and display the whole phrases at once, or simply drop the
> translation markers on the descriptions (since our templates are
> currently English-only anyway).

Ok. Frankly leaning towards not translating, especially given the test
output changes. When we've tackled translation of the boring static
parts of hgweb, we can revisit this.

If anyone's interested in this, a good first step towards that goal is
adding a template syntax for translatables that it can no-op for now.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list