[PATCH 0 of 2] reduce possibility of skipping check-code when not desired

Mads Kiilerich mads at kiilerich.com
Mon Nov 11 18:39:07 CST 2013


On 11/12/2013 12:40 AM, Simon Heimberg wrote:
> check-code.py was skipped on entire files by accident.
>
> The current pragma "no-check-code" was accidentally used in code (in check-code.py itself).

Exactly where did that happen? And why not just fix that instead of 
redefining and "complexify" something that is simple and works fine?

/Mads

> Patch 1 adresses mainly this by requiring "# no-check-code".
>
> Patch 2 adresses the problem of skipping the entire file instead of skipping only one line.
> The pragma must be in a comment on a separate line. And it must be near start of file
> (as in polib.py) or near end of file (as in httpclient).
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list