[PATCH 1 of 2 stable] context: drop caching 'copies' method
Mads Kiilerich
mads at kiilerich.com
Mon Nov 11 21:08:17 CST 2013
# HG changeset patch
# User Mads Kiilerich <madski at unity3d.com>
# Date 1384225286 -3600
# Tue Nov 12 04:01:26 2013 +0100
# Branch stable
# Node ID 82165da0edded3801c421273d49ebccbf382878a
# Parent ba6486076429e5c20d910b8a5d4f8acf1e9dc1b1
context: drop caching 'copies' method
The 'copies' method has no test coverage and calls copies.pathcopies with an
incorrect number of parameters and is thus (fortunately) not used. Kill it.
diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -8,7 +8,6 @@
from node import nullid, nullrev, short, hex, bin
from i18n import _
import ancestor, mdiff, error, util, scmutil, subrepo, patch, encoding, phases
-import copies
import match as matchmod
import os, errno, stat
import obsolete as obsmod
@@ -722,14 +721,6 @@ class basefilectx(object):
c = visit.pop(max(visit))
yield c
- def copies(self, c2):
- if not util.safehasattr(self, "_copycache"):
- self._copycache = {}
- sc2 = str(c2)
- if sc2 not in self._copycache:
- self._copycache[sc2] = copies.pathcopies(c2)
- return self._copycache[sc2]
-
class filectx(basefilectx):
"""A filecontext object makes access to data related to a particular
filerevision convenient."""
More information about the Mercurial-devel
mailing list