[PATCH 3 of 3] template: Change extras to use showlist rather thanmanual templ calll

Sean Farley sean.michael.farley at gmail.com
Fri Nov 15 17:07:04 CST 2013


matthewturk at gmail.com writes:

> # HG changeset patch
> # User Matthew Turk <matthewturk at gmail.com>
> # Date 1384555377 18000
> #      Fri Nov 15 17:42:57 2013 -0500
> # Node ID 47549382f99bd0b753f8ce7d787050d32f4890f5
> # Parent  b78c4813b053fd84eaf19b0df289d96d67e25b48
> template: Change extras to use showlist rather than manual templ call.

Another bad capitalized 'Change' but this patch looks good otherwise.

> This enables start_extras and end_extras in template maps.
>
> diff -r b78c4813b053 -r 47549382f99b mercurial/templatekw.py
> --- a/mercurial/templatekw.py	Fri Nov 15 17:14:02 2013 -0500
> +++ b/mercurial/templatekw.py	Fri Nov 15 17:42:57 2013 -0500
> @@ -221,11 +221,8 @@
>  def showextras(**args):
>      """:extras: List of dicts with key, value entries of the 'extras'
>      field of this changeset."""
> -    templ = args['templ']
> -    for key, value in sorted(args['ctx'].extra().items()):
> -        args = args.copy()
> -        args.update(dict(key=key, value=value))
> -        yield templ('extra', **args)
> +    yield showlist('extra', sorted(dict(key=a, value=b)
> +                   for (a, b) in args['ctx'].extra().items()), **args)
>  
>  def showfileadds(**args):
>      """:file_adds: List of strings. Files added by this changeset."""
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list