[PATCH] tests: remove python link during cleanup

Sean Farley sean.michael.farley at gmail.com
Fri Nov 15 20:20:26 CST 2013


mads at kiilerich.com writes:

> On 11/15/2013 08:35 PM, Sean Farley wrote:
>> # HG changeset patch
>> # User Sean Farley <sean.michael.farley at gmail.com>
>> # Date 1384462134 18000
>> #      Thu Nov 14 15:48:54 2013 -0500
>> # Node ID 38c5f62b663a4e1f2d0a301fbfd8aa375caa218d
>> # Parent  c38c3fdc8b9317ba09e03ab09364c3800da7c50c
>> tests: remove python link during cleanup
>
> Why? What problem do it solve?

The problem is that a random link is created in the mercurial directory
that keeps showing up as "? python" in "hg status".

> Why should python be removed from BINDIR if the other things we do with 
> BINDIR shouldn't?
>
> And how secure will this be if run-tests is run with --with-hg pointing 
> at a hg installed somewhere special?

Hmm, that's a good question. Probably not a good thing.

> (Run-tests is fragile and could use some major clean-ups. Apparently 
> good changes like this can easily break other obscure use cases.)

I'd rather it not create the link in the first place but I don't know
the code that well to know.


More information about the Mercurial-devel mailing list