[PATCH 2 of 2 stable] bisect: --command without --noupdate should flag the parent rev it tested

Matt Mackall mpm at selenic.com
Fri Nov 22 14:37:04 CST 2013


On Sun, 2013-11-10 at 18:58 +0100, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski at unity3d.com>
> # Date 1384105882 -3600
> #      Sun Nov 10 18:51:22 2013 +0100
> # Branch stable
> # Node ID 278f54215117d5fde0122ce366b49180dead23fb
> # Parent  a19429a57d1b9386eba4775929a4e82fd3070d74
> bisect: --command without --noupdate should flag the parent rev it tested

I've spent 15 minutes looking at this and I'm afraid I don't understand
this description. Please provide an example.

> 14913fcb30c6 not only introduced a revset predicate, it also changed how
> --noupdate works in combination with --command. But more important: It also
> introduced what seems like a bug, that --command would flag the revision
> tracked as "current" instead of the parent revision that actually had been used
> when running the command. This patch partly restores the old behavior.

> 1388cc711ea7 made the combination of --command and --noupdate more useful but
> did still not clarify exactly what was intended and why. I would expect that it
> should use the parent revision or the revision specified with --rev. Starting
> out with the 'current' revision (which at this point arguably is more like the
> previous revision and already has been tested) seems wrong. Anyway, the
> behavior in that case is not changed by this patch.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list