[PATCH] get-with-headers: don't block indefinitely if the server had an internal error

[Augie Fackler]

On Oct 4, 2013, at 4:12 AM, Javi Merino <cibervicho at gmail.com> wrote:

> On Thu, Oct 03, 2013 at 10:45:51AM -0400, Augie Fackler wrote:
>> On Wed, Oct 02, 2013 at 11:03:19PM +0100, Javi Merino wrote:
>>> # HG changeset patch
>>> # User Javi Merino <cibervicho at gmail.com>
>>> # Date 1380750392 -3600
>>> #      Wed Oct 02 22:46:32 2013 +0100
>>> # Node ID c135513fb69b57d869eb98c23cef2f5c3fab54e7
>>> # Parent  1935e8383a9e1bd1ac6809ad1ecafd42dd7d58b2
>>> get-with-headers: don't block indefinitely if the server had an internal error
>>> 
>>> If the server had an internal error and returned 500, there's nothing
>>> to read, so "response.read()" blocks indefinitely.  Only output the
>>> response if there's really a response.
>> 
>> Bwuh? There can be a body on a 500. This strikes me as probably
>> wrong. Can you give an example of a case that hangs?
> 
> If mercurial fails to install templates, some tests in the testsuite
> hang.  You can force the not installing templates when running the
> testsuite with:

This is the wrong fix - Mercurial shouldn't produce invalid 500 responses if the templates are missing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20131005/b6b060fb/attachment.pgp>