[PATCH] changegroup: don't run changegroup hooks if nodes are gone

Durham Goode durham at fb.com
Wed Oct 9 11:32:06 CDT 2013


On 10/7/13 2:17 PM, "Durham Goode" <durham at fb.com> wrote:

># HG changeset patch
># User Durham Goode <durham at fb.com>
># Date 1381171501 25200
>#      Mon Oct 07 11:45:01 2013 -0700
># Node ID 572bf59dd5950cefc2c00a20fbfee9fdf65a8176
># Parent  b3de50b0c7aa464fdf73ece8c4e5ee8af59b4242
>changegroup: don't run changegroup hooks if nodes are gone
>
>The changegroup hook runs when the repo lock is released, but it's
>possible that
>multiple transactions have happened during that single lock and therefore
>the
>commits the hook was for may be gone. This is the case in the shelve
>extension
>where it adds a commit and strips it in the same lock but different
>transactions (which results in warning messages during unshelve on
>hgsubversion
>repos).
>
>A real fix would be to attach the hook to the transaction instead, but
>that
>might have unknown consequences. Since we're this close to code-freeze,
>this fix
>just prevents the hook from running if the commit disappeared.

Ping. This patch is blocking us from deploying shelve at Facebook, so it'd
be nice to get it in so we can get some real user feedback/bugs before the
2.8 release.



More information about the Mercurial-devel mailing list