[PATCH] pager: honour aliases (issue3532)

[Durham Goode]

On 10/16/13 8:14 AM, "David Soria Parra" <dsp at experimentalworks.net> wrote:

>On 10/16/2013 07:22 AM, Augie Fackler wrote:
>> On Sat, Oct 12, 2013 at 07:01:58PM -0700, David Soria Parra wrote:
>>> # HG changeset patch
>>> # User David Soria Parra <dsp at experimentalworks.net>
>>> # Date 1381629094 25200
>>> #      Sat Oct 12 18:51:34 2013 -0700
>>> # Node ID 39084a836b0525cbcabc60b5200e83a5cd91577d
>>> # Parent  1b2f9d36953e6ed384a044c1e73cb3a1aa072004
>>> pager: honour aliases (issue3532)
>> 
>> Hm, I could see going both ways on this. After all, using an alias is
>> one of the "normal" ways to bypass configuration on a given command,
>> isn't it?
>> 
>> I don't use pager though, so it won't matter for me one way or the
>>other.
>> 
>
>Yes it's definatly argueable, but I think in most cases once you decide
>that your alias is on the attend list you also want aliases. E.g i use
>bm as an abbrev for bookmarks and have some shortcuts for log, so it's a
>bit annoying to have an increasing attend list.
>
>In case we decide against allowing aliases I'll followup with a patch
>that at least takes fixed aliases such as history|log into account. In
>that case I think it's clear, if you attend log you also want hg history
>to page.

I'm in favor of this change.  In our setup here we have an attend list set
in the system level hgrc on everyone's machine.  If someone adds a
personal alias for log that uses their own template, they are unable to
add it to the attend list without overwriting the system level one.  It
would be much more convenient if aliases for log were automatically paged
as well.