[PATCH] localrepo: invoke only feature setup functions for enabled extensions

Siddharth Agarwal sid0 at fb.com
Sat Oct 19 20:20:50 CDT 2013


On 10/17/2013 05:48 AM, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1382013917 -32400
> #      Thu Oct 17 21:45:17 2013 +0900
> # Node ID 2d01803ef7a896e114e7983022fe40ceb7823346
> # Parent  aebfbb68fe9277803d9f68943bf2e63391bd08c5
> localrepo: invoke only feature setup functions for enabled extensions
>
> Before this patch, each feature setup functions for localrepository
> class should examine whether corresponding extension is enabled or not
> by themselves.
>
> This patch invokes only feature setup functions defined in module of
> enabled extensions, and it makes implementation of feature setup
> functions easier and simpler.

I have a slight preference for making featuresetup a magic function just 
like uisetup or reposetup, but I'm not going to fight over that. Looks 
good to me, unless mpm has a stronger preference.


More information about the Mercurial-devel mailing list